Update architecture docs for unified test provider#3313
Open
sebtiem wants to merge 5 commits intoapache:masterfrom
Open
Update architecture docs for unified test provider#3313sebtiem wants to merge 5 commits intoapache:masterfrom
sebtiem wants to merge 5 commits intoapache:masterfrom
Conversation
Signed-off-by: Sebastian Tiemann <setie@mailbox.org>
…ormation Signed-off-by: Sebastian Tiemann <setie@mailbox.org>
Signed-off-by: Sebastian Tiemann <setie@mailbox.org>
…tures to architecture.md Signed-off-by: Sebastian Tiemann <setie@mailbox.org>
Signed-off-by: Sebastian Tiemann <setie@mailbox.org>
sparsick
reviewed
Mar 11, 2026
| | **maven-failsafe-plugin** | Runs integration tests during `integration-test` / `verify` phases | | ||
| | **maven-surefire-report-plugin** | Generates HTML test reports from XML results | | ||
|
|
||
| Surefire supports JUnit 3, JUnit 4, JUnit 5 (Jupiter), TestNG, and plain POJO tests — each via a dedicated **provider** module. Tests execute in a **forked JVM** that communicates results back to Maven through a binary event stream protocol. |
Contributor
There was a problem hiding this comment.
I think with the change in 3.6.x we will not have dedicated provider module for each test framework.
| ### Key relationships | ||
|
|
||
| - **Both plugins** (`surefire-plugin`, `failsafe-plugin`) share all logic via `maven-surefire-common`. The failsafe plugin adds pre/post-integration-test lifecycle binding and a different default report directory. | ||
| - **Providers are not compile dependencies** of the plugins. They are resolved at runtime by `SurefireDependencyResolver` and loaded in the forked JVM's classpath. |
Contributor
There was a problem hiding this comment.
I would change providers (plural) to junit platform provider (single)
Member
There was a problem hiding this comment.
well regarding what we provide it's true.
But the provider architecture is still in place and users are still able to "provide" their own provider
|
|
||
| | Provider | Module | Test framework | Key classes | | ||
| |----------|--------|---------------|-------------| | ||
| | **JUnit 3 + POJO** | `surefire-junit3` | JUnit 3.x, plain POJOs | `JUnit3Provider`, `PojoTestSetExecutor` | |
Contributor
There was a problem hiding this comment.
I would not delete the table, but move it to subchapter 3.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@olamy Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.